Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import codebase from thoughtbot #1

Closed
croaky opened this issue Feb 21, 2012 · 6 comments
Closed

Import codebase from thoughtbot #1

croaky opened this issue Feb 21, 2012 · 6 comments

Comments

@croaky
Copy link
Contributor

croaky commented Feb 21, 2012

Remove things like KISSMetrics, New Relic, accounts, subscriptions, plans, limits.

@croaky
Copy link
Contributor Author

croaky commented Feb 21, 2012

I began ripping out the thoughtbot-specific code tonight. Things like KISSMetrics, Tender, email/password authentication, accounts, plans, limits, billing, Braintree, terms of service, privacy policy, contact page, email delivery, Google Analytics, Heroku, Airbrake, announcements, A/B testing, and New Relic are now gone.

I'll need to return to it Wednesday night to spend some more time fixing up the tests and some of the new user interface flows. I'm hoping to move the code into this repo by the end of the week.

@kareemk
Copy link
Member

kareemk commented Feb 22, 2012

@croaky sounds good although i imagine some of these services you're removing most people will want to run in their production environments. are you envisioning that everyone will have to fork the project to configure for their specific environment?

@croaky
Copy link
Contributor Author

croaky commented Feb 23, 2012

I think the only ones that people might want are Heroku, Airbrake, and New Relic. I'd rather not force people to decide to use them and let them pick and choose. All are super-simple to set up oneself.

@patricksrobertson
Copy link
Contributor

Agreed on configuration of Airbrake and New Relic on Heroku.

@croaky have you made any progress on the preparation lately?

I understand this is less than glamorous work but at the same time I'd like have a couple of iterations before the shutdown to setup a staging/production environment to minimize potential risk with the switchover. If that's not possible, I can plan to switch to a static version of the i18n keys we use until you feel good about the codebase.

croaky pushed a commit that referenced this issue Mar 5, 2012
@croaky
Copy link
Contributor Author

croaky commented Mar 5, 2012

I've got a version pushed here. I've removed things like private keys, plans/accounts/subscriptions/users/limits, KISSMetrics/New Relic/Airbrake. I also eliminated the Redis dependency to make it slightly easier and cheaper for people to run this on their own. It still requires a background worker via Delayed::Job.

The test suite is green under Ruby 1.9.2 and I successfully deployed it from scratch to Heroku's Cedar stack.

I aimed for utter simplicity as I was re-working the code to be open sourced so you'll notice the project drop-down / current_project concept is gone. I'd also like to go with HTTP Auth per-project to simplify user accounts / admins / permissions.

I'm going to create a few issues tomorrow night and re-work some of the user flows. Patrick, do you want to meet at the Boston Ruby hackfest at thoughtbot on Tuesday night to work on some things together?

@croaky croaky closed this as completed Mar 5, 2012
@patricksrobertson
Copy link
Contributor

Sounds like a plan @croaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants