Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fiat-crypto is using too much memory for our workers #10566

Closed
ejgallego opened this issue Jul 24, 2019 · 6 comments

Comments

@ejgallego
Copy link
Member

commented Jul 24, 2019

Unfortunately we seem to get workers that lack just a bit of memory to handle fiat-crypto successfully quite often.

I dunno how to proceed here, @JasonGross ?

cc: #8993 #9338 #10353

@JasonGross

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Which file? I recently added a file (PerfTesting/Core) that uses quite a lot of memory (because it vm_computes an enormous term), but I can remove / disable that part of things if needed. If it's some other file, I'll have to think more.

@JasonGross

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

(Recently = a couple of weeks ago)

@ejgallego

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

Timing seems about right indeed, and that's the file creating problems so it seems:
https://gitlab.com/coq/coq/-/jobs/258615768

Finished failing transaction in 195.771 secs (31.645u,3.139s) (failure)
File "./src/Rewriter/PerfTesting/Core.v", line 286, characters 2-72:
Error: Out of memory.

@ejgallego

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

It'd be great to add a workaround then, do we need some change on Coq's part?

@JasonGross

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Should be fixed now

@ejgallego

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

Thanks a lot Jason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.