Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #9885 CoqIDE does not work on Windows #10360

Merged
merged 1 commit into from Jun 13, 2019

Conversation

@MSoegtropIMC
Copy link
Contributor

commented Jun 11, 2019

  • Switch gtksourceview to 3.24.11
  • Add appropriate set of icons and some other files GTK3 requires
  • Add fix for ocamldebug so that this can be debugged

@MSoegtropIMC MSoegtropIMC changed the title Resolve 9885 CoqIDE does not work on Windows Resolve #9885 CoqIDE does not work on Windows Jun 11, 2019

@vbgl

vbgl approved these changes Jun 11, 2019

Copy link
Contributor

left a comment

Thanks Michael for fixing CoqIDE on Windows!

Show resolved Hide resolved dev/build/windows/makecoq_mingw.sh Outdated
Resolve #9885 CoqIDE does not work on Windows
- Switch gtksourceview to 3.24.11
- Add appropriate set of icons and some other files GTK3 requires
- Add fix for ocamldebug so that this can be debugged

@MSoegtropIMC MSoegtropIMC force-pushed the MSoegtropIMC:issue-9885-CoqIDE-gtk3-win branch from 57fb6a6 to a5c2268 Jun 11, 2019

@MSoegtropIMC

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

I fixed the typo and also the shell lint error => should be ready to go.

@vbgl vbgl added this to the 8.10.0 milestone Jun 11, 2019

@ejgallego

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Thanks a lot @MSoegtropIMC ! By the way, we'd like to add Windows CI support to the main lablgtk3 repository, so the risk of breaking the windows build is minimized. What is the setup do you recommend us to follow?

@MSoegtropIMC

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

@ejgallego : this will be quite tricky because to see the bug fixed here one has to do UI interactions. I am not sure if GTK has something like an event recording and playback mechanism, so that one could automate UI test cases. There are other options, but the (reasonably robust) methods I know of require proprietary UI interaction reco
rders and players.

@ejgallego

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@MSoegtropIMC I guess that as a first step we would be happy ensuring compilation and basic examples work on the right environment, so that's indeed the main question, which win + unix subsystem should we choose for our CI?

@MSoegtropIMC

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

@ejgallego : I am working on a cygwin/opam/dune based development (and eventually also release) build system for Coq. I would use that. It uses a special cygwin/mingw opam repo, though. I can see if the lablgtk examples work this way. The opam repo I mentioned has binary ocaml packages, so that setup and test should be fairly quick this way.

@ejgallego

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Sounds good @MSoegtropIMC , are you coordinating with the OCaml / OPAM windows maintainers of that will be a separate thing?

@MSoegtropIMC

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

@ejgallego : for me it is a bit hard to tell what the "official" Windows opam repo is. I am using this:

https://github.com/fdopen/opam-repository-mingw

which did build Coq and its prerequisites and infrastructure tools out of the box with only minor patches (which are already integrated in this repo). This repo appears to be well maintained. But I don't have the impression that this is the "official" Windows opam repo. Do you have an overview?

@ejgallego

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Do you have an overview?

I think that is as official as one can get today, certainly when Windows support becomes more official in they'll start from there.

@vbgl

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Can someone take care of merging this? Otherwise I will.

@ejgallego ejgallego self-assigned this Jun 13, 2019

@ejgallego ejgallego added the kind: fix label Jun 13, 2019

@coqbot coqbot added this to Request 8.10.0 inclusion in Coq 8.10 Jun 13, 2019

@ejgallego ejgallego merged commit a5c2268 into coq:master Jun 13, 2019

7 checks passed

GitLab CI pipeline Pipeline completed on GitLab CI
Details
coq.coq Build #20190611.26 succeeded
Details
coq.coq (Windows) Windows succeeded
Details
coq.coq (macOS) macOS succeeded
Details
doc:ml-api:odoc: ml-api artifact Link to ml-api build artifact.
Details
doc:refman: refman artifact Link to refman build artifact.
Details
doc:refman: stdlib artifact Link to stdlib build artifact.
Details

ejgallego added a commit that referenced this pull request Jun 13, 2019

Merge PR #10360: Resolve #9885 CoqIDE does not work on Windows
Reviewed-by: ejgallego
Reviewed-by: vbgl

vbgl added a commit to vbgl/coq that referenced this pull request Jun 13, 2019

@Zimmi48

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

@vbgl Now that this PR has been merged, and while waiting for the template polymorphism critical bug fix, I'd recommend to release a second beta, even if it is only for one week, like we did with @maximedenes with 8.7+beta2 because CoqIDE was not usable on Windows in 8.7+beta1. If you agree, I can take care of moving the unreleased changelog entries to the Recent changes chapter, and renaming the milestone and project columns.

Zimmi48 added a commit to Zimmi48/coq that referenced this pull request Jun 13, 2019

cpitclaudel added a commit that referenced this pull request Jun 14, 2019

@vbgl

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

A second round of β is a good idea. Your help on the change-log and github stuff is much appreciated. Thanks.

vbgl added a commit to vbgl/coq that referenced this pull request Jun 14, 2019

Add missing changelog entry for coq#10360.
(cherry picked from commit a05f42f)

vbgl added a commit to vbgl/coq that referenced this pull request Jun 14, 2019

@coqbot coqbot moved this from Request 8.10.0 inclusion to Shipped in 8.10.0 in Coq 8.10 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.