New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override build date with SOURCE_DATE_EPOCH #11227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this does not work as noted by Gaëtan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch @bmwiedemann , it looks good to me!
IMHO we should document this variable in configure -help, so I propose you add a brief documentation and fix the indentation while you are at it.
|
I don't think it should go into But if you still want it, I will not be unhappy. I would just need some help finding the right place to patch. |
@bmwiedemann your call, you are the expert here. I am fine merging as is; if you want to add some documentation the easiest would be to tweak the "Available options" message I certainly didn't know about the variable even if I am a bit familiar with RB. |
|
Here or elsewhere (e.g. |
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Fixes coq#11037
|
@Zimmi48 added some lines to INSTALL. Can you think of a better way to place/word it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wording does look pretty good to me.
Reviewed-by: Zimmi48 Reviewed-by: ejgallego
|
Thanks for your quick and helpful feedback. For the remaining other issue I opened #11229 |
Allow to override build date with
SOURCE_DATE_EPOCHin order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
Kind: documentation / bug fix / feature / performance / infrastructure.
Fixes / closes #11037
This PR was done while working on reproducible builds for openSUSE.