Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build date with SOURCE_DATE_EPOCH #11227

Merged
merged 1 commit into from Dec 2, 2019

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Dec 2, 2019

Allow to override build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Kind: documentation / bug fix / feature / performance / infrastructure.

Fixes / closes #11037

  • Added / updated test-suite

This PR was done while working on reproducible builds for openSUSE.

configure.ml Outdated Show resolved Hide resolved
configure.ml Outdated Show resolved Hide resolved
@Zimmi48 Zimmi48 added kind: infrastructure CI, build tools, development tools. part: build The build system. labels Dec 2, 2019
@ejgallego ejgallego self-assigned this Dec 2, 2019
@ejgallego ejgallego added the needs: fixing The proposed code change is broken. label Dec 2, 2019
Copy link
Member

@ejgallego ejgallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this does not work as noted by Gaëtan.

Copy link
Member

@ejgallego ejgallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @bmwiedemann , it looks good to me!

IMHO we should document this variable in configure -help, so I propose you add a brief documentation and fix the indentation while you are at it.

configure.ml Outdated Show resolved Hide resolved
@bmwiedemann
Copy link
Contributor Author

bmwiedemann commented Dec 2, 2019

I don't think it should go into configure -help output, because people doing reproducible builds already know very well about this variable, because it is used for gcc, rpm and so many more tools.
And other people will probably not need it.

But if you still want it, I will not be unhappy. I would just need some help finding the right place to patch.

@ejgallego
Copy link
Member

I don't think it should go into configure -help output, because people doing reproducible builds already know very well about this variable, because it is used for gcc, rpm and so many more tools.

@bmwiedemann your call, you are the expert here. I am fine merging as is; if you want to add some documentation the easiest would be to tweak the "Available options" message parse_args () = ...

I certainly didn't know about the variable even if I am a bit familiar with RB.

Copy link
Member

Zimmi48 commented Dec 2, 2019

Here or elsewhere (e.g. INSTALL file) but that Coq supports this absolutely needs to be documented beyond the changelog.

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Fixes coq#11037
@bmwiedemann
Copy link
Contributor Author

@Zimmi48 added some lines to INSTALL. Can you think of a better way to place/word it?

Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording does look pretty good to me.

@Zimmi48 Zimmi48 added this to the 8.11.0 milestone Dec 2, 2019
@ejgallego ejgallego merged commit 80bd376 into coq:master Dec 2, 2019
ejgallego added a commit that referenced this pull request Dec 2, 2019
Reviewed-by: Zimmi48
Reviewed-by: ejgallego
@coqbot coqbot added this to Request 8.11.0 inclusion in Coq 8.11 Dec 2, 2019
@bmwiedemann bmwiedemann deleted the date branch December 2, 2019 18:01
@bmwiedemann
Copy link
Contributor Author

Thanks for your quick and helpful feedback.

For the remaining other issue I opened #11229

ppedrot added a commit to ppedrot/coq that referenced this pull request Dec 7, 2019
@coqbot coqbot moved this from Request 8.11.0 inclusion to Shipped in 8.10.0 in Coq 8.11 Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: infrastructure CI, build tools, development tools. part: build The build system.
Projects
No open projects
Coq 8.11
  
Shipped in 8.11.0
Development

Successfully merging this pull request may close these issues.

binaries contain build time
4 participants