Unfortunate Coq 8.10 bug with "cofix with" tactic syntax #11241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herbelin
added
kind: fix
Failing on CProdN([],...) was maybe a bit too radical.
herbelin
force-pushed
the
master+bug-cofix-with-8.10
branch
from
36a3d8f
to
eff3606
Compare
Zimmi48
approved these changes
Dec 5, 2019
ejgallego
added a commit
that referenced
this pull request
Dec 5, 2019
…ntax Reviewed-by: Zimmi48 Reviewed-by: ejgallego
Zimmi48
moved this from Request 8.11+beta1 inclusion
to Request 8.11.0 inclusion
in Coq 8.11
ppedrot
added a commit
to ppedrot/coq
that referenced
this pull request
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coq 8.10 added an internal invariant that
blis non empty isCProdN(bl,c). Unfortunately, thecofix withtactic was not respecting this invariant.This fixes the issue.
Kind: bug fix
May it be ported to 8.10?