[test] Upgrade base OCaml to 4.08.1 #11580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Effectively at least mtac2 does fail with: will report a bug for coq_makefile in time. Also, the 32bit suite failure is quite suspicious, due to native ints again. |
Hopefully, this is fixed by #11805 |
Stronger linking restrictions were introduced in OCaml 4.08, I'd like to have a look at what the impact is over the CI.
|
Thanks @proux01 , PR rebased on top of your fix. |
|
I will close this PR and turn this into an issue once I have minute; the issue seems quite serious to me; Dune + findlib provide a fix; but even with that is still a lot of work. |
|
Issue in #12067 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stronger linking restrictions were introduced in OCaml 4.08, I'd like
to have a look at what the impact is over the CI.