New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extraction] [Haskell] Add support for GHC >= 9 #14345
Conversation
No.
I don't think so. If you have some time, please check my recent comment: #14256 (comment). |
The tests in |
Sure. I will test this fix with GHC 8.01, 8.02, and 8.10.4 (but unfortunately Stack does not seem to support GHC 9 yet). If I don't see any issue, I will push a fix for the test-suite and merge. |
@pi8027 Thanks for the update! I've updated this PR a bit further, since as I discovered in #14256 (comment) the change to |
(Sorry for being so belated in updating this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm it works at least with GHC 7.10.3, 8.0.1, 8.0.2, and 8.10.4.
@JasonGross Thanks. Just to be sure, did you test the output with GHC 9? If so, I think this is ready to merge as soon as CI passes. |
I did not, as I don't have easy access to it. I am basing the change on the tags of ghc/ghc@74ad75e, which indicate that it first showed up in 9.0 |
But I have tested effectively the same change with GHC 9 on Fiat-Crypto CI using https://github.com/mit-plv/fiat-crypto/blob/master/src/haskell.sed, so unless I've made a typo, it works |
OK, that seems fine with me. Let's merge. |
@coqbot: merge now |
Kind: bug fix
Fixes #14256
https://github.com/coq/coq/blob/master/dev/ci/user-overlays/README.md for details)