Handle delayed opaque proofs in Print Assumptions #14382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppedrot
force-pushed
the
assumptions-delayed-opaque
branch
from
bc0c623
to
382c226
Compare
SkySkimmer
reviewed
May 25, 2021
|
https://gitlab.com/coq/coq/-/jobs/1291081315 is not happy |
|
@SkySkimmer yes, it seems like the binary called by the script doesn't like the |
Instead of using Global.body_of_constant_body and tinkering with the result we roll up our own version of the accessor which is delayed-proof-aware. Fixes coq#13589: Print Assumptions for vok.
I find the code clearer that way, as it clearly indicates intent.
ppedrot
force-pushed
the
assumptions-delayed-opaque
branch
from
382c226
to
060deaf
Compare
|
Let's try a bit of cargo culting to see whether it works. I mimicked the script in the vos folder, which calls the |
|
I guess -vok is passed to the worker (incorrectly). |
ppedrot
force-pushed
the
assumptions-delayed-opaque
branch
from
060deaf
to
198acb4
Compare
|
Seems to be OK now. |
SkySkimmer
approved these changes
May 25, 2021
|
@coqbot: merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using Global.body_of_constant_body and tinkering with the result we roll up our own version of the accessor which is delayed-proof-aware.
Fixes #13589: Print Assumptions for vok.
Supersedes #13614.