Fixes #15451: incompletenesses in guard condition regarding cofix and primitive projections #15498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herbelin
added
kind: fix
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Jan 17, 2022
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Jan 17, 2022
herbelin
force-pushed
the
master+fix15451-incompleteness-guard-condition
branch
from
0a42adf
to
9026195
Compare
Alizter
reviewed
Jan 17, 2022
kernel/inductive.ml
Outdated
| | Construct _ -> | ||
| check_rec_call renv [] | ||
| | Construct _ | CoFix _ -> | ||
| check_rec_call renv stack | ||
| (Term.applist (mkProj(Projection.unfold p,c), l)) | ||
| | _ -> Exninfo.iraise exn |
There was a problem hiding this comment.
Why not make this explicit so we definitely don't forget any cases?
There was a problem hiding this comment.
Good question. We could but there are a lot of cases to add. Wondering what others would do themselves.
There was a problem hiding this comment.
I think that in the kernel at least, it is considered good practice to fully enumerate the constructors of constr.
There was a problem hiding this comment.
I agree, the catch-all bit me once in the guard as well when we introduced primitive projections.
herbelin
force-pushed
the
master+fix15451-incompleteness-guard-condition
branch
from
9026195
to
359dafd
Compare
ppedrot
approved these changes
Jan 28, 2022
|
This one is fairly simple and there is little risk of anything going wrong, so let me assign and merge. |
|
@coqbot merge now |
SkySkimmer
pushed a commit
to SkySkimmer/coq
that referenced
this pull request
Mar 18, 2022
(cherry picked from commit 359dafd)
SkySkimmer
added a commit
to SkySkimmer/coq
that referenced
this pull request
Mar 18, 2022
…dition regarding cofix and primitive projections
coqbot-app
bot
moved this from Request 8.15.1 inclusion
to Shipped in 8.15.1
in Coq 8.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind: Fix
Two issues:
cofixwas missing when detecting the presence of a potential iota-redex to reduceFixes #15451