Clean the API of the congruence plugin #16527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is inefficient and exposing internal details. It is the responsibility of the cc algorithm not to produce broken proofs, so there is little point in double-checking the output.
SkySkimmer
approved these changes
Sep 22, 2022
|
Not sure what the |
|
This ensures that there are no way to produce an axiom out of an arbitrary constr. If you look into the internals, now it's clear that there are only two kinds of axioms: either a single variable or a variable applied to a bunch of ATerms.t. |
Alizter
approved these changes
Sep 22, 2022
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove from the API stuff that is exported but clearly internal details, and enforce a few invariants by typing.