From e4adb19d016cbb37014e8c2ed830d794a4ca9087 Mon Sep 17 00:00:00 2001
From: Hugo Herbelin <Hugo.Herbelin@inria.fr>
Date: Sat, 30 Dec 2023 11:59:35 +0100
Subject: [PATCH 1/2] Fixes #18434: arguments of --external in coqdoc were
 swapped.

---
 tools/coqdoc/cmdArgs.ml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/coqdoc/cmdArgs.ml b/tools/coqdoc/cmdArgs.ml
index 8a81fa45180d..310d579d2643 100644
--- a/tools/coqdoc/cmdArgs.ml
+++ b/tools/coqdoc/cmdArgs.ml
@@ -180,7 +180,7 @@ let args_options = Arg.align [
   "--verbose", arg_set (fun p -> { p with quiet = false }), " Verbose mode";
   "--no-externals", arg_set (fun p -> { p with externals = false }),
   " No links to Coq standard library";
-  "--external", arg_url_path Index.add_external_library,
+  "--external", arg_url_path (fun url lp -> Index.add_external_library lp url),
   "<url>+<d> set URL for external library <d>";
   "--coqlib_url", arg_string (fun p u -> { p with coqlib_url = u }),
   "<url> Set URL for Coq standard library (default: " ^ Coq_config.wwwstdlib ^ ")";

From efd66340d6e7ec012910bc0a52f909e86872b679 Mon Sep 17 00:00:00 2001
From: Hugo Herbelin <Hugo.Herbelin@inria.fr>
Date: Sat, 30 Dec 2023 20:35:40 +0100
Subject: [PATCH 2/2] Change log for #18448

---
 .../18448-master+fix18434-coqdoc-external-regression.rst    | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 doc/changelog/09-cli-tools/18448-master+fix18434-coqdoc-external-regression.rst

diff --git a/doc/changelog/09-cli-tools/18448-master+fix18434-coqdoc-external-regression.rst b/doc/changelog/09-cli-tools/18448-master+fix18434-coqdoc-external-regression.rst
new file mode 100644
index 000000000000..ac9de01fa631
--- /dev/null
+++ b/doc/changelog/09-cli-tools/18448-master+fix18434-coqdoc-external-regression.rst
@@ -0,0 +1,6 @@
+- **Fixed:**
+  Regression in option :g:`--external` of `coqdoc`, whose two arguments
+  were inadvertently swapped
+  (`#18448 <https://github.com/coq/coq/pull/18448>`_,
+  fixes `#18434 <https://github.com/coq/coq/issues/18434>`_,
+  by Hugo Herbelin).