-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lang: Clearer error when handling not initialized accounts #1024
Conversation
Since this only more details errors and |
@fanatid And to be honest, I just moved our internal trait to anchor, since this is how we check if the account is initialized or not. 😅 |
b28e40a
to
49679a4
Compare
I see CI dropped on some tests, I'll figure it out and fix it a little later |
3596b62
to
5c440d6
Compare
We need a record about a new error in CHANGELOG.md |
It would be nice if we will have a test somewhere for a new error. |
66d95d6
to
2cbd973
Compare
@@ -13,7 +13,11 @@ incremented for features. | |||
|
|||
### Fixes | |||
|
|||
lang: Add `deprecated` attribute to `ProgramAccount` ([#1014](https://github.com/project-serum/anchor/pull/1014)). | |||
* lang: Add `deprecated` attribute to `ProgramAccount` ([#1014](https://github.com/project-serum/anchor/pull/1014)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the whole CHANGELOG, you don't have single items without a "*" at the beginning. I thought it was a typo and corrected it. Boy Scout Rule 😅
LGTM, thanks for the test! |
The newly added test fails. |
Fixed. CI passed @armaniferrante Is there a way to immediately run tests with updated clients in JS? Or I just need to learn how repos CI do it? UPD: |
@armaniferrante Do I still need to improve PR somehow? Let me know please |
I alias the path to my local CLI build and either yarn link or set the file path to the local ts build in the test. Not clean, but it's easy and gets the job done. Would be awesome to see future changes that handled this more elegantly. |
Close #1015
ErrorCode::AccountNotInitialized
Account::try_from
&Account::try_from_unchecked