-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for mutability of init payer #1271
Merged
paul-schaaf
merged 5 commits into
coral-xyz:master
from
losman0s:man0s/init-mut-payer-check
Feb 8, 2022
Merged
Add check for mutability of init payer #1271
paul-schaaf
merged 5 commits into
coral-xyz:master
from
losman0s:man0s/init-mut-payer-check
Feb 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losman0s
force-pushed
the
man0s/init-mut-payer-check
branch
9 times, most recently
from
January 9, 2022 19:28
a030d6a
to
b724f1c
Compare
paul-schaaf
reviewed
Jan 10, 2022
paul-schaaf
reviewed
Jan 10, 2022
paul-schaaf
reviewed
Jan 10, 2022
paul-schaaf
reviewed
Jan 10, 2022
losman0s
force-pushed
the
man0s/init-mut-payer-check
branch
7 times, most recently
from
January 11, 2022 17:50
babdf55
to
9be57a9
Compare
paul-schaaf
reviewed
Feb 4, 2022
@losman0s had one comment. apart from that, LGTM |
This was referenced Feb 6, 2022
losman0s
force-pushed
the
man0s/init-mut-payer-check
branch
from
February 7, 2022 19:44
8997de5
to
74086b6
Compare
losman0s
force-pushed
the
man0s/init-mut-payer-check
branch
from
February 8, 2022 16:29
54a6852
to
d5cbf79
Compare
losman0s
force-pushed
the
man0s/init-mut-payer-check
branch
from
February 8, 2022 17:08
d5cbf79
to
8f39eb8
Compare
Thanks @losman0s! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No compile-time check is done to ensure that an account specified as payer for an
init
-ed account is mutable.This leads to confusion, when added to the fact that the Anchor client automatically marks the wallet payer as mutable even when the IDL does not have it marked mutable (often masking the lack of
mut
attribute in the account validation struct).Summary of Changes
Add cross-account mutability check between
init
-ed account and associated payer account.Fixes #1219