lang: fix clobbered module names on IDL parsing (ready for review) #1343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing the crate to generate the IDL; the parser naively assumes that all files in the crate have unique names (sans the path).
I found this when I had something like e.g.:
The parser is maintaining a key-value store from module-names to parsed modules. The name is being generated from the filename and ignores the path; so multiple files with the same name in the same crate get over written with only the last one parsed remaining in the data structure.
This PR simply adds the path to the key; the key itself appears to be arbitrary and never consumed and is only to avoid duplication.
Here is an example repo which illustrates this problem:
https://github.com/gdoteof/anchor-idl-parse-bug/tree/main/programs/idl_parse_bug/src
This is the IDL generated after the changes in this pr: