Attempt to reduce test flakiness by forcing file sync #1457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some automated testing has shown this test to fail due to being unable
to read the written version bytes from the file. The root cause would
seem to be something at the OS level, so do a sync_all() to hopefully
ensure that the immediate read after write sees the contents of the
write.
We (Solana) build against this repo as part of our CI to ensure we don't break things (at least compilation 😄 ); this test has been failing intermittently for us (one such instance) as follows:
Hypothetically, I don't think this change should be strictly necessary; however, I have previously observed issues with unit tests that write a file and immediately read it afterwards.