-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lang: add support for logging expected and actual values and pubkeys #1572
Merged
paul-schaaf
merged 21 commits into
coral-xyz:master
from
paul-schaaf:lang/dynamic-errors
Mar 15, 2022
Merged
lang: add support for logging expected and actual values and pubkeys #1572
paul-schaaf
merged 21 commits into
coral-xyz:master
from
paul-schaaf:lang/dynamic-errors
Mar 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1586
closes #1464
Future PRs should add more
require
statements that abstract away the implementation detailsmacros added in this PR:
require_eq
macro that is meant to be used with non-pubkey values and results in the following output:require_keys_eq
macro that is meant to be used with pubkey values and results in the following output:These macros can be used like this
require_eq(value1, value2)
in which case they return an error defined by us or with a custom errorrequire_eq(value1,value2,MyError:SomeError)
. Therequire
macro has also been changed to work the same wayLog statement are intentionally
Left
andRight
and notExpected
andActual
because futurerequire
macros would not fit those descriptions (e.g.require_gt
)