Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust to v1.62 #2272

Merged
merged 8 commits into from
Nov 22, 2022
Merged

Update rust to v1.62 #2272

merged 8 commits into from
Nov 22, 2022

Conversation

Henry-E
Copy link

@Henry-E Henry-E commented Nov 22, 2022

  • Just updating from 1.56 to 1.65.
  • Have a horrible feeling this introduces some new clippy lint that complains about the Result<> size being too large. For now will need to find a way to disable that particular lint globally since it shows up so many places?

@vercel
Copy link

vercel bot commented Nov 22, 2022

Someone is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Henry-E Henry-E changed the title Update rust to v1.65 Update rust to v1.64 Nov 22, 2022
@Henry-E
Copy link
Author

Henry-E commented Nov 22, 2022

Looks like it has to be 1.64 because that's what the github CI supports at the moment. 🤷 At least we don't have to deal with the clippy lint about large result types.

For future reference a .clippy.toml file in the root directory containing large-error-threshold = 1_000_000 will disable the lint pretty easily.

@Aursen
Copy link
Contributor

Aursen commented Nov 22, 2022

Thx for the update, I will change my code

@Henry-E Henry-E changed the title Update rust to v1.64 Update rust to v1.62 Nov 22, 2022
@Henry-E
Copy link
Author

Henry-E commented Nov 22, 2022

Now we're all the way back down to v1.62 because that's what the current solana cli version supports. Going to keep this in mind next time I try to update the rust version 😂

@Henry-E
Copy link
Author

Henry-E commented Nov 22, 2022

Also finally passing, time to merge.

@Henry-E Henry-E merged commit 5291a7b into coral-xyz:master Nov 22, 2022
Henry-E pushed a commit to Henry-E/anchor that referenced this pull request Dec 6, 2022
* update rust from v1.56 to v1.65

* remove unnecessary borrows to appease clippy

* stop clippy complaining for now

* use 1.64 instead because of CI stuff

* update CHANGLEOG

* just seeing if the cli version is affecting the available rust version

* ok, back to 1.62

Co-authored-by: henrye <henry@notanemail>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants