Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing env vars to verifiable build container #2325

Merged
merged 7 commits into from
Dec 21, 2022

Conversation

riordanp
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Dec 19, 2022

@riordanp is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Henry-E
Copy link

Henry-E commented Dec 20, 2022

Is there much else you still want to add to this PR? It looks pretty reasonable to add.

Also

  • don't forget to run cargo fmt
  • please add a note to the changelog as well

@riordanp
Copy link
Contributor Author

Should be ready now

@riordanp riordanp marked this pull request as ready for review December 20, 2022 17:51
@Henry-E
Copy link

Henry-E commented Dec 20, 2022

Looks like a clippy lint still needs to be satisfied or excepted somehow. https://github.com/coral-xyz/anchor/actions/runs/3742902170/jobs/6354794762

Also it's weird the changelog isn't registering as a merge conflict because it looks like you don't have version of the changelog in which 0.26.0 has already been released (we launched it last week). So your change should be the first new feature in the unreleased version. Sorry to be anal about the changelog stuff but it's just hard for me to rebase your repo / update the changelog manually when it's out of sync.

@Henry-E Henry-E merged commit 8856aee into coral-xyz:master Dec 21, 2022
dovahcrow pushed a commit to dovahcrow/anchor that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants