lang: Handle arrays with const as length #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated this to panic with an error if there is another const in the crate with the same name that is usize and has a different value. I think that is preferable. |
tomlinton
force-pushed
the
tomlinton/idl-const-array-size
branch
2 times, most recently
from
7d0251a
to
d580425
Compare
tomlinton
changed the title
|
Thank you for this @tomlinton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces variables in array definitions with their value. One clear limitation is that if the same const is declared in different places in the crate with different values this might not use the correct one. Hopefully an uncommon case, but definitely keen on suggestions!
Closes #335
Closes #294