New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterizing the Dockerfile #213

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@saranrapjs
Copy link

saranrapjs commented Apr 6, 2016

What does this PR do?

At present, the Dockerfile for Cay is missing a config.json; this branch creates one from environment variables. I was trying to get a working docker "cluster" running via docker-compose, and it seemed like some of the components weren't quite parameterized yet.

How do I test this PR?

Build with:
docker build -t "coralproject/cay" .

Then you can spin the built image up, passing in environment variables like so:

docker run -p 80:80 --name cayapp \
    -e "CAY_XENIAHOST=https://coraldemo.coralproject.net/xenia_api" \
    -e "CAY_PILLARHOST=https://coraldemo.coralproject.net/pillar_api" \
    -e "CAY_AUTH=Basic NmQ3MmU2ZGQtOTNkMC00NDEzLTliNGMtODU0NmQ0ZDM1MTRlOlBDeVgvTFRHWjhOdGZWOGVReXZObkpydm4xc2loQk9uQW5TNFpGZGNFdnc9" \
    coralproject/cay

(I've nabbed the working environment/config.json values from here: https://github.com/coralproject/reef/blob/master/docker/config.json)

....I realize I could be stepping on someone's behind-the-scene Docker work here, so feel free to ignore if there are other plans for how these things fit together!

@jde

This comment has been minimized.

Copy link
Contributor

jde commented Apr 7, 2016

Great idea to include the env vars in the dockerfile. @edefikh @samshub Thoughts?

@edefikh

This comment has been minimized.

Copy link
Contributor

edefikh commented Apr 12, 2016

Our current config.json file uses few parameters , I am working on parameterizing them.

@saranrapjs

This comment has been minimized.

Copy link

saranrapjs commented Apr 12, 2016

@edefikh is this in line with what you're working on, or completely different?

@edefikh

This comment has been minimized.

Copy link
Contributor

edefikh commented Apr 12, 2016

This commit has the details on how I am adding config.json file as parameters: 667c901

@edefikh

This comment has been minimized.

Copy link
Contributor

edefikh commented May 26, 2016

This issue can be resolved, the new docker compose YML file uses variables as parameters for starting app.

@edefikh edefikh closed this May 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment