Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO bugs out sometimes on IE #1956

Open
striedinger opened this Issue Oct 2, 2018 · 10 comments

Comments

Projects
None yet
2 participants
@striedinger
Copy link

commented Oct 2, 2018

Do you want to request a feature or report a bug?

Bug

Intended outcome:

Click on Sign in with (Google/Facebook), and successfully log in after external log in.

Actual outcome:

Successfully authenticate with external provider, popup closes, but no login in Talk. Login button still available and when trying to login using any method none will work.

How to reproduce the issue:

  • Log in using external provider
  • Immediately log out.
    (Here it gets tricky as I have not found the exact steps that cause the bug)
    Either:
  • Log in, refresh page while logged in, log out and try to log in.
  • Log in, log out, refresh page, try to log back in.
  • Log in, open page in another browser (Chrome) and log in, close other browser tab, Log out from IE, try to log back in.
  • Log in, log out, open page in another browser (Chrome) and log in, try to log back in.

I am sorry I can't be more specific but it is not as recurring, but when it happens I would say it is a breaking bug as it messes the whole system. The only way I have found out to make it work again is close the browser itself and open back the page to log in again.

Version and environment

Talk 4.5 on IE11

@wyattjoh

This comment has been minimized.

Copy link
Member

commented Oct 2, 2018

Are you currently using any non-required configuration for your instance? We just released some fixes related to social sign on in 4.6.4 when using TALK_STATIC_URI.

@striedinger

This comment has been minimized.

Copy link
Author

commented Oct 2, 2018

@wyattjoh only customization we are doing is enabling google and facebook auth plugins with a docker on build file. Although we are using 4.5. Will try to upgrade to 4.6.4 in the AM and come back with results.

@striedinger

This comment has been minimized.

Copy link
Author

commented Oct 3, 2018

@wyattjoh I upgraded to 4.6.4 and bug is still happening. I definitely consider this a bug since my instance is up and running perfectly with no issues whatsoever. It's just on a rare occurrence that when doing those steps provided it bugs out on IE and login with OAuth messes up.

@wyattjoh

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

I've just attempted to perform the testing you suggested on IE 11 against our blog (running at https://coralproject.net/blog/happy-hacktoberfest/) and I can't seem to reproduce the error you described. If you can reproduce but provide any console logs that occurred, that would be helpful in ensuring that we have the best picture of the problem.

@striedinger

This comment has been minimized.

Copy link
Author

commented Oct 3, 2018

@wyattjoh I just got it on your blog. I havent found a way to keep developer tools open on IE11 after window (popup in this case) closes. But I pretty much did the same thing. Log in, log out, refresh page, try to log in again or log in, refresh, log out and try to log back in. Eventually it bugs out and prevents any type of logging in to happen.

@wyattjoh

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

Do you have any browser plugins installed? Any non-standard testing?

I just ran through your steps about 5 times on Browserstack Windows 10 IE11 without any issues so far.

@striedinger

This comment has been minimized.

Copy link
Author

commented Oct 3, 2018

Clean browser. Nothing out of the ordinary apart from doing what I mentioned. I am going to try to record it and will back to post it when I have it.

@striedinger

This comment has been minimized.

Copy link
Author

commented Oct 3, 2018

talk_bug
@wyattjoh - Like I mentioned earlier, it's a pretty damn difficult bug to reproduce. But when it does happen, and sometimes it happens even easier, it is breaking as it completely disables login. I would imagine a non-tech person would be frustrated if this were to happen and just give up on commenting.

@wyattjoh

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

Do you think you could open the console on the blog page to see if anything is being posted there?

@striedinger

This comment has been minimized.

Copy link
Author

commented Oct 4, 2018

@wyattjoh Nothing pops up in console on the blog page. It's very easy to reproduce when following those steps, it eventually will bug out.

@wyattjoh wyattjoh self-assigned this Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.