New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom onbuild image size is double the base image #2075

Open
dberhane opened this Issue Nov 13, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@dberhane
Copy link

dberhane commented Nov 13, 2018

I am a new Coral Talk user and have a basic understanding of Docker. I’ve successfully installed Coral Talk (v4.6.5) on our development environment. I am now in the process of enabling Plugins.

To enable one extra plugin, I have used the basic docker “onbuild” image Dockerfile, a directory of plugins and a plugins.json file (which lists the activated plugins).

The new image container is working well and could see the new plugin enabled. My only concern is that the new image size is 810MB which is almost of twice the size of the base image (443MB). I’ve only enabled one additional plugin. Should I be concerned about the image size?

@kgardnr kgardnr added the question label Nov 13, 2018

@wyattjoh

This comment has been minimized.

Copy link
Member

wyattjoh commented Nov 13, 2018

Thanks for the report @dberhane!

Unfortunately, we're currently blocked on the following yarn bug: yarnpkg/yarn#4764

It seems whenever we run yarn, it will touch every file in node_modules each time, which causes issues with how docker detects changed files, thereby increasing the image size.

We're replacing yarn with npm in Talk v5, which does not have this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment