Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPassing asset_id to Coral.Talk.render() hangs #2176
Comments
This comment has been minimized.
This comment has been minimized.
What does the logs referencing the internal error show? |
This comment has been minimized.
This comment has been minimized.
I am not sure which logs you are referring to. I checked the docker logs for the talk container and nothing out of the ordinary. The error message appears in the browser in a black div at the bottom of the view point. Can you point me to a relevant log? Thanks. |
This comment has been minimized.
This comment has been minimized.
@kaichristiansen The |
This comment has been minimized.
This comment has been minimized.
Yes. I have included it. I am using the docker onbuild image and including it as a server plugin. |
This comment has been minimized.
This comment has been minimized.
Ah. I think I found the problem. The doc for the plugin on git (https://github.com/coralproject/talk-plugin-custom-asset-id) shows adding the plugin with a line like this: {"@coralproject/talk-plugin-custom-asset-id": "^1.1.0"} which works for installing the plugin but does not work at runtime. I changed it to: "talk-plugin-custom-asset-id", and then installed the plugin directly using git clone and now it is no longer hanging. It moves on to reveal another error related to the docker container and https/ssl but I will pursue that separately. |
kaichristiansen commentedFeb 3, 2019
I am having a similar issue to this older closed issue. I commented there and maybe should reopen that? Not sure of the best protocol. #1720
I am trying to pass an asset_id to the render method and it hangs.I have installed the plugin which I can see in the node_modules folder inside the talk docker container installation. When I test this locally, I get a "Graph QL: error: Internal Error" popup at the bottom of the viewport and then a spinning waiter in the blank comment div. My code looks like this:
Coral.Talk.render(document.getElementById('coral_talk_stream'), {
talk: '',
lazy: true,
asset_id: '92ae9e52-1fdf-11e7-a7a3-001851cded07'
});
I have tried it with and without asset_url. If I comment out asset_id it works fine. Is it possible the plugin is not working or in inactive?