Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of Source sans pro font #2237

Open
GlynnPhillips opened this Issue Mar 21, 2019 · 0 comments

Comments

Projects
None yet
3 participants
@GlynnPhillips
Copy link
Contributor

commented Mar 21, 2019

Potential improvement

I have noticed that the Source sans pro web font is downloaded for all views rendered by Talk because it is included in the base template. This results in it get loaded during the render of the embed component.

As far as I can tell this font is then only ever referenced in an admin stylesheet which is only used on a couple of pages and never in the embeds.

Suggestion 1

My first suggestion is to remove this from the base template so its not downloaded by the end user viewing the embeded component.

Suggestion 2

However I have a further suggestion which would remove it entirely and rely on system fonts instead. I have produced this as an example commit for your consideration.

My reasoning for this suggestion is that custom css relies on overrides so if a developer using Talk wishes to use their own fonts they would be forcing an unnecessary download on the user.

Suggestion 3

There could also be a potential middle ground if Coral wished to keep a default theming/brand which included web fonts but this I imagine would require it to become a configuration option.

@GlynnPhillips GlynnPhillips changed the title Remove the use of Source sans pro Remove the use of Source sans pro font Mar 21, 2019

@wyattjoh wyattjoh added this to the v4.9.0 milestone Mar 21, 2019

@kgardnr kgardnr removed this from the v4.8.4 milestone Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.