Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove the use of Source sans pro font #2237
I have noticed that the Source sans pro web font is downloaded for all views rendered by Talk because it is included in the base template. This results in it get loaded during the render of the embed component.
As far as I can tell this font is then only ever referenced in an admin stylesheet which is only used on a couple of pages and never in the embeds.
My first suggestion is to remove this from the base template so its not downloaded by the end user viewing the embeded component.
However I have a further suggestion which would remove it entirely and rely on system fonts instead. I have produced this as an example commit for your consideration.
My reasoning for this suggestion is that custom css relies on overrides so if a developer using Talk wishes to use their own fonts they would be forcing an unnecessary download on the user.
There could also be a potential middle ground if Coral wished to keep a default theming/brand which included web fonts but this I imagine would require it to become a configuration option.