Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Talk Email Authentication #2316

Open
ianwelsh opened this issue May 17, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@ianwelsh
Copy link

commented May 17, 2019

We would like to disable "Talk Email Authentication" and only allow users to sign in via Facebook. Is this possible? We tried removing the talk-plugin-local-auth plugin but the Email and Password fields still show in the Login pop up.

Here is the output of ./bin/cli plugins list, talk-plugin-local-auth is not in the list of installed plugins:


 +local     (l)  packages in your project
 +external  (e)  packages are external
 +outofdate (oe) packages are external but are out of date
 +missing   (m)  packages are not found

 l  talk-plugin-featured-comments
 l  talk-plugin-respect
 l  talk-plugin-rich-text
 l  talk-plugin-profile-data
 l  talk-plugin-notifications
 l  talk-plugin-notifications-category-featured
 l  talk-plugin-notifications-category-moderation-actions
 l  talk-plugin-notifications-category-reply
 l  talk-plugin-notifications-category-staff
 l  talk-plugin-notifications-digest-hourly
 l  talk-plugin-notifications-digest-daily
 l  talk-plugin-facebook-auth
 l  talk-plugin-akismet
 l  talk-plugin-sort-newest
 l  talk-plugin-sort-oldest
 l  talk-plugin-sort-most-replied
 l  talk-plugin-deep-reply-count
 l  talk-plugin-auth
 l  talk-plugin-author-menu
 l  talk-plugin-featured-comments
 l  talk-plugin-flag-details
 l  talk-plugin-member-since
 l  talk-plugin-moderation-actions
 l  talk-plugin-respect
 l  talk-plugin-rich-text
 l  talk-plugin-viewing-options
 l  talk-plugin-sort-most-replied
 l  talk-plugin-sort-most-respected
 l  talk-plugin-sort-newest
 l  talk-plugin-sort-oldest
 l  talk-plugin-profile-data
 l  talk-plugin-notifications
 l  talk-plugin-notifications-category-featured
 l  talk-plugin-notifications-category-moderation-actions
 l  talk-plugin-notifications-category-reply
 l  talk-plugin-notifications-category-staff
 l  talk-plugin-notifications-digest-hourly
 l  talk-plugin-notifications-digest-daily
 l  talk-plugin-ignore-user
 l  talk-plugin-facebook-auth
 l  talk-plugin-akismet
 l  talk-plugin-comment-content
 l  talk-plugin-permalink
@immber

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

It's possible, however if you have any Admin or Moderator users that will not be using FB for authentication, it might not be advisable, as those users will still need to use email/pwd for login.

The email and password sign in dialog and it's components are a part of talk-plugin-auth, however, because the talk-plugin-facebook-auth depends on some other stuff in talk-plugin-auth, it will not work to simply disable talk-plugin-auth.

If you'd like to remove those, I'd suggest making a local copy of talk-plugin-auth, renaming it to something like "talk-plugin-custom-auth", and removing any of the client components that you'd like to disable. That way you can keep the client/server functionality that talk-plugin-facebook-auth is depending on while customizing the client components.

When working on client side changes to a plugin, it's helpful to note that Talk requires .a rebuild in order to for client plugin changes to be registered!

@kgardnr kgardnr added the question label May 22, 2019

@ianwelsh

This comment has been minimized.

Copy link
Author

commented May 23, 2019

I'm getting the client-side error below when opening the log in pop up using a custom auth plugin. I get this output even if the contents of my custom plugin are identical to the talk-plugin-auth (I copied contents of plugins/talk-plugin-auth to plugins/talk-plugin-custom-auth and replaced talk-plugin-auth with talk-plugin-custom-auth in plugins.json and rebuilt). Is there something I'm missing here?

Also, is there a way to keep the client-side JS un-minified so it can be debugged in the browser?

bundle.7bba36083b6d8af513d8.js:80 Uncaught (in promise) TypeError: Cannot read property 'view' of undefined
    at e (bundle.7bba36083b6d8af513d8.js:80)
    at a.e [as configureFinalMapState] (bundle.7bba36083b6d8af513d8.js:80)
    at a.e [as computeStateProps] (bundle.7bba36083b6d8af513d8.js:80)
    at a.e [as updateStatePropsIfNeeded] (bundle.7bba36083b6d8af513d8.js:80)
    at a.e [as render] (bundle.7bba36083b6d8af513d8.js:80)
    at d._renderValidatedComponentWithoutOwnerOrContext (bundle.7bba36083b6d8af513d8.js:66)
    at d._renderValidatedComponent (bundle.7bba36083b6d8af513d8.js:66)
    at d.performInitialMount (bundle.7bba36083b6d8af513d8.js:66)
    at d.mountComponent (bundle.7bba36083b6d8af513d8.js:66)
    at Object.mountComponent (bundle.7bba36083b6d8af513d8.js:66)
e @ bundle.7bba36083b6d8af513d8.js:80
e @ bundle.7bba36083b6d8af513d8.js:80
e @ bundle.7bba36083b6d8af513d8.js:80
e @ bundle.7bba36083b6d8af513d8.js:80
e @ bundle.7bba36083b6d8af513d8.js:80
_renderValidatedComponentWithoutOwnerOrContext @ bundle.7bba36083b6d8af513d8.js:66
_renderValidatedComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountChildren @ bundle.7bba36083b6d8af513d8.js:66
_createInitialChildren @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
performInitialMount @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
mountComponent @ bundle.7bba36083b6d8af513d8.js:66
I @ bundle.7bba36083b6d8af513d8.js:66
perform @ bundle.7bba36083b6d8af513d8.js:66
D @ bundle.7bba36083b6d8af513d8.js:66
perform @ bundle.7bba36083b6d8af513d8.js:66
batchedUpdates @ bundle.7bba36083b6d8af513d8.js:66
j @ bundle.7bba36083b6d8af513d8.js:66
_renderNewRootComponent @ bundle.7bba36083b6d8af513d8.js:66
_renderSubtreeIntoContainer @ bundle.7bba36083b6d8af513d8.js:66
render @ bundle.7bba36083b6d8af513d8.js:66
e @ bundle.7bba36083b6d8af513d8.js:1
m @ bundle.7bba36083b6d8af513d8.js:80
o @ bundle.7bba36083b6d8af513d8.js:80
e.<computed> @ bundle.7bba36083b6d8af513d8.js:80
r @ bundle.7bba36083b6d8af513d8.js:1
(anonymous) @ bundle.7bba36083b6d8af513d8.js:1
Promise.then (async)
r @ bundle.7bba36083b6d8af513d8.js:1
(anonymous) @ bundle.7bba36083b6d8af513d8.js:1
(anonymous) @ bundle.7bba36083b6d8af513d8.js:1
t @ bundle.7bba36083b6d8af513d8.js:1
./client/coral-login/src/index.js @ bundle.7bba36083b6d8af513d8.js:1
n @ bundle.7bba36083b6d8af513d8.js:1
multi babel-polyfill /usr/src/app/client/coral-framework/helpers/webpackGlobals /usr/src/app/client/coral-login/src/index @ bundle.7bba36083b6d8af513d8.js:80
n @ bundle.7bba36083b6d8af513d8.js:1
(anonymous) @ bundle.7bba36083b6d8af513d8.js:1
(anonymous) @ bundle.7bba36083b6d8af513d8.js:1
Show 29 more frames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.