Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Idea: Add hash option to permalink plugin's "Share" link #2330

Open
AndrewGibson27 opened this issue May 28, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@AndrewGibson27
Copy link

commented May 28, 2019

The permalink plugin is quite handy. Our only issue is the link created when you click "Share" doesn't contain a hash allowing you to jump users down to where the Talk embed actually is. Having the option to include one would be fantastic ... and could (maybe) be accomplished using some text in a translations.yml file?

Screen Shot 2019-05-28 at 4 44 59 PM

We've thought about adding some code in our website to detect whether a URL contains ?commentId and then appending the proper hash from there. But that feels a bit hacky and we'd prefer to have the "Share" URL be the source of truth.

Thanks!

@mkonikov

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

FWIW On our site we do load the comments section when commentId query is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.