Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next] Custom CSS #2377

Open
cristiandean opened this issue Jun 24, 2019 · 13 comments

Comments

Projects
None yet
4 participants
@cristiandean
Copy link
Contributor

commented Jun 24, 2019

Hello, we are working with Coral Talk (next branch) and we feel it’s hard to customize the default embed stream using the Custom CSS feature. It would be nice if the components had more friendly selectors. What do you think? I can help with a PR if necessary.

Thank you

@kgardnr

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Hey @cristiandean! We would LOVE if you would help us out with this, it's on our list but hasn't been prioritized yet, it would be really helpful! 🥇

@kgardnr

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Hey @cristiandean we are going to get some info together for you from the team on naming conventions that should be helpful for you!

@cristiandean

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

@kgardnr

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Alright, @cristiandean, we're good to go! So the only thing you need to do is prefix every classname with coral-, so for example, coral-featured-comments-tab-header.

@cvle

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Hey @cristiandean, thanks for wanting to help us. To put this into scope, you could make a PR that adds the selectors for your own customization needs. That way we'll see what you need and we'll work something out together.

Did you have a different idea besides using classnames as selectors?

In case of using classnames, here are some guidelines for the naming of the classnames:

Some examples could be coral-tabBar, coral-tabBar-allCommentsTab

@cristiandean

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

Alright, @kgardnr and @cvle, thanks for your support. I'll open the PR and any questions I'll post there.

@kgardnr

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

Hey @cristiandean, are you still planning on working on this? It will become a blocker for us by next week, so if you can't get to it this week, let us know!

@cristiandean

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

Hey @kgardnr, I've been kind of busy the last few days, but I plan to start developing this feature tomorrow. I can't say that it will be ready until next week, because other things may happen along the way. What are you planning to do may hinder a future merge?

@kgardnr

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Hey @cristiandean! That sounds good. We're looking to cut the official v5.0.0 by end of this month and will need that in there. So I think it might be better if we just do it, unless you think you'll be able to?

@cristiandean

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@kgardnr If it's not a problem for you, it's fine with me you do it. I was already in about 20% of the task and had to stop because of another more prioritized task of our backlog :/

Anyway, thanks for the support. =)

@gjtorikian

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Wrong person. 😀

@cristiandean

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

I'm sorry @gjtorikian :)

@kgardnr

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

Hey @cristiandean we have a PR for this - wanna take a look and give us your feedback? Feel free to add on if you'd like! #2414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.