Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Changed email and unconfirmed when requireEmailConfirmation is true should not allow user to do comment. #2494
I just found a probably a bug on Talk. The description is below.
Do you want to request a feature or report a bug?
Probably a bug.
If talk settings
User can change the email, receive the notification on email to confirm the new email but talk still allowing user to comment if he is still logged on Talk.
How to reproduce the issue:
Version and environment
4.9.1 (but seems to be a bug on all versions)
Add a new phase on moderation an verify both
Would be great to have some feedback from you about it and I can take this issue and send a PR. :)
Fine, makes sense the team stay focused on v5 as the release of the final version will be soon, but we have Talk running on v4 and would be great to fix on that too. That's why I asked a feedback about to my proposed solution.
if you are not keen to accept a pull request on v4 about it, then I will need to think about what I can do to not have problems about maintenance in the future because of core changes (not a good idea).