Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n Validator #2953

Merged
merged 3 commits into from May 7, 2020
Merged

i18n Validator #2953

merged 3 commits into from May 7, 2020

Conversation

wyattjoh
Copy link
Collaborator

@wyattjoh wyattjoh commented May 5, 2020

What does this PR do?

Based on the work by @cristiandean, this ports the script written to TS and uses the language parser to extract the keys.

What changes to the GraphQL/Database Schema does this PR introduce?

None.

How do I test this PR?

Run the example below:

./scripts/i18n/validate.ts pt-BR

@wyattjoh wyattjoh requested a review from tessalt May 5, 2020 19:00
Copy link
Contributor

@tessalt tessalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool this will be so helpful

@wyattjoh wyattjoh merged commit 1624787 into master May 7, 2020
@wyattjoh wyattjoh deleted the i18n-checker branch May 7, 2020 16:07
@kgardnr kgardnr added this to the v6.2.0 milestone May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants