New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow replacing comment timestamp #979

Merged
merged 6 commits into from Sep 22, 2017

Conversation

Projects
None yet
3 participants
@cvle
Copy link
Member

cvle commented Sep 20, 2017

What does this PR do?

New slots commentTimestamp and historyCommentTimestamp to allow replacing the comment date e.g. 10 minutes ago with a custom component

How do I test this PR?

  • Add components to the above slots to a new or existing plugin and see it replacing the timestamp on the comment stream and comment history.

cvle added some commits Sep 20, 2017

@cvle cvle requested review from kgardnr and okbel Sep 20, 2017

@cvle cvle changed the title Pluginize timestamp Allow replacing comment timestamp Sep 20, 2017

@kgardnr

This comment has been minimized.

Copy link
Member

kgardnr commented Sep 21, 2017

I'm good with this once @okbel gives it a thumbs up!

@@ -2,7 +2,7 @@ import React from 'react';
import PropTypes from 'prop-types';

import TagLabel from 'talk-plugin-tag-label/TagLabel';
import PubDate from 'talk-plugin-pubdate/PubDate';

This comment has been minimized.

@okbel

okbel Sep 21, 2017

Member

I'm glad we are removing this. talk-plugin...


CommentTimestamp.propTypes = {
className: PropTypes.string,
created_at: PropTypes.string,

This comment has been minimized.

@okbel

okbel Sep 21, 2017

Member

I'm not going to bring up the casing again 😛

This comment has been minimized.

@cvle

cvle Sep 21, 2017

Member

oh well..

This comment has been minimized.

@cvle

cvle Sep 21, 2017

Member

This one should be camel case I guess.. >.<

@okbel

This comment has been minimized.

Copy link
Member

okbel commented Sep 21, 2017

Code looks good. I'm testing it right now.

@okbel

okbel approved these changes Sep 21, 2017

@kgardnr kgardnr merged commit f183aeb into master Sep 22, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@kgardnr kgardnr deleted the pluginize-timestamp branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment