Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to docker image : compatible with v3.3; image size; truststore #4954

Open
rickcrook opened this issue Mar 28, 2019 · 3 comments
Open

Comments

@rickcrook
Copy link
Contributor

@rickcrook rickcrook commented Mar 28, 2019

Great to see official docker images for corda.

A few improvements if I might be so bold:

  1. backward compatible with 3.3 : add -- to initial-registration in generate-config.sh
  2. Remove hardcoding : Use ${CONFIG_FOLDER}/node.conf in run-corda.sh
  3. backward compatible with 3.3 : remove = from --config-file= in run-corda.sh
  4. Docker image size : delete yum cache
  5. Docker image size : minimize number of layer using Docker best practises
  6. Maintainability : Default JVM_ARGS and CORDA_ARGS in Dockerfile rather than run-corda.sh
  7. UX : Add network-root-truststore to improve onboarding process to Corda.Network UAT and stop two-stage deploy process
  8. Security : Remove EXPOSE from Dockerfiles. Ports should be exposed at run-time not build-time.

Happy to raise a PR if there is desire for these changes

@Bartman250

This comment has been minimized.

Copy link
Contributor

@Bartman250 Bartman250 commented Mar 28, 2019

I don't recommend exposing the p2p ports in the dockerfile as if you are running in docker compose, a docker 'swarm' or kubernetes network or in vpn, you don't need to expose these ports

@Bartman250

This comment has been minimized.

Copy link
Contributor

@Bartman250 Bartman250 commented Mar 28, 2019

Ideally - the docker file paths should be compatible with the 'deployNodes' directory structure - so that it is easy to migrate to docker locally in dev mode - and it saves the joy of try to sus out where all the directories and files need to go (So far spent nearly 2 days trying to figure this out in front of clients) !.

@rickcrook

This comment has been minimized.

Copy link
Contributor Author

@rickcrook rickcrook commented Mar 31, 2019

Image size post #4965

REPOSITORY                          TAG                 CREATED             SIZE
corda/corda-zulu-5.0-snapshot       latest              3 hours ago         692MB
corda/corda-zulu-5.0-snapshot       20190329190533      2 days ago          716MB
corda/corda-zulu-4.0                RELEASE             5 weeks ago         712MB

corda/corda-corretto-5.0-snapshot   latest              3 hours ago         660MB
corda/corda-corretto-5.0-snapshot   20190329190533      2 days ago          1.19GB
corda/corda-corretto-4.0            RELEASE             5 weeks ago         1.16GB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.