New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORDA-2088: Simplified the TestCordapp public API #4064

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@shamsasari
Member

shamsasari commented Oct 12, 2018

The entry point to the API has been simplified to just requireing a list of packages to scan, with sensible defaults provided for the metadata. Because of the wither methods, having parameters for the metadata (with default values) seems unnecessary. Also the ability to scan just individual classes has been made internal, as it seems unlikely app developers would need that level of control when testing their apps.

TestCordappImpl is a data class and thus just acts as a natural key for the Jar caching, where previously the key was the package names. This fixes an issue where it was not possible to create two CorDapp Jars of the same package but different metadata.

@shamsasari shamsasari changed the title from temp to CORDA-2088: Simplified the TestCordapp public API Oct 12, 2018

@shamsasari shamsasari requested a review from sollecitom Oct 12, 2018

CORDA-2088: Simplified the TestCordapp public API
The entry point to the API has been simplified to just requireing a list of packages to scan, with sensible defaults provided for the metadata. Because of the wither methods, having parameters for the metadata (with default values) seems unnecessary. Also the ability to scan just individual classes has been made internal, as it seems unlikely app developers would need that level of control when testing their apps.

TestCordappImpl is a data class and thus acts as a natural key for the Jar caching, where previously the key was the package names. This fixes an issue where it was not possible to create two CorDapp Jars of the same package but different metadata.
@shamsasari

This comment has been minimized.

Member

shamsasari commented Oct 15, 2018

It's all green finally. I had to fix some tests.

@shamsasari shamsasari merged commit 2c9a942 into master Oct 15, 2018

4 checks passed

API Stability (Pull Requests) TeamCity build finished
Details
Build Pull Requests (Docs) TeamCity build finished
Details
Integration Tests (Pull Requests) TeamCity build finished
Details
Unit Tests (Pull Requests) TeamCity build finished
Details

@shamsasari shamsasari deleted the shams-testcordapp-revisit branch Oct 15, 2018

roastario pushed a commit to roastario/corda that referenced this pull request Nov 8, 2018

CORDA-2088: Simplified the TestCordapp public API (corda#4064)
The entry point to the API has been simplified to just requireing a list of packages to scan, with sensible defaults provided for the metadata. Because of the wither methods, having parameters for the metadata (with default values) seems unnecessary. Also the ability to scan just individual classes has been made internal, as it seems unlikely app developers would need that level of control when testing their apps.

TestCordappImpl is a data class and thus acts as a natural key for the Jar caching, where previously the key was the package names. This fixes an issue where it was not possible to create two CorDapp Jars of the same package but different metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment