dte.data_models: add 'DteXmlData' #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step of making possible to have separate models without breaking other project's code.
glarrain
force-pushed
the
feature/dte/data-models/add-dtexmldata
branch
from
17056c7 to
2cf2fbe
Compare
glarrain
changed the title
jtrh
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add data model
DteXmlData, which is exactly the same (regarding fields) asDteDataL2.The ultimate goal is having separate models with different fields. This is the first step of making that possible without breaking other project's code.
Function
parse_dte_xmlreturn type is nowDteXmlDatainstead ofDteDataL2.