Skip to content

Conversation

@glarrain
Copy link
Contributor

For subclasses of RcvDetalleEntry only one of these fields is necessary, which depends on the specific class.

  • emisor_razon_social
  • receptor_razon_social

These fields had been made optional in #112 (commit 1f21463).

For subclasses of `RcvDetalleEntry` only one of these fields is
necessary, which depends on the specific class.

- `emisor_razon_social`
- `receptor_razon_social`

These fields had been made optional in #112 (commit 1f21463).
@glarrain glarrain added enhancement New feature or request component: rcv labels Apr 14, 2020
@glarrain glarrain requested a review from jtrh April 14, 2020 23:38
@glarrain glarrain self-assigned this Apr 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #116 into develop will increase coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #116      +/-   ##
===========================================
+ Coverage    77.33%   78.00%   +0.67%     
===========================================
  Files           25       25              
  Lines         1725     1705      -20     
  Branches       286      278       -8     
===========================================
- Hits          1334     1330       -4     
+ Misses         267      255      -12     
+ Partials       124      120       -4     
Impacted Files Coverage Δ
cl_sii/rcv/data_models.py 53.89% <ø> (+3.89%) ⬆️
cl_sii/rcv/parse_csv.py 78.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d454c8...1a3597e. Read the comment docs.

@glarrain glarrain merged commit 502209f into develop Apr 14, 2020
@glarrain glarrain deleted the feature/rcv/data_models/remove-unnecessary-fields branch April 14, 2020 23:47
@glarrain glarrain mentioned this pull request Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: rcv enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants