Skip to content

rtc: Add constants and "cesión" natural keys #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2021
Merged

rtc: Add constants and "cesión" natural keys #174

merged 3 commits into from
Jan 7, 2021

Conversation

@jtrh
Copy link
Contributor

@jtrh jtrh commented Jan 5, 2021 •
edited
Loading

  • constants: Add 'monto cedido' and 'sequence number'.
  • data_models: Add "cesión" natural key and alternative natural key.
  • data_models_cesiones_periodo: Replace hardcoded values with constants.

@jtrh jtrh self-assigned this Jan 5, 2021
@jtrh jtrh requested a review from glarrain January 5, 2021 20:03
@jtrh jtrh force-pushed the feature/add-sii-rtc-constants-and-cesion-nat-keys branch from dcdb7ad to 6d620a0 Compare January 5, 2021 20:15
@jtrh jtrh marked this pull request as ready for review January 5, 2021 20:15
@jtrh jtrh force-pushed the feature/add-sii-rtc-constants-and-cesion-nat-keys branch from 07418b9 to c15c0a6 Compare January 5, 2021 22:11
jtrh added 3 commits January 6, 2021 17:43
@jtrh
rtc.constants: Add 'monto cedido' and 'sequence number'
3e620ec
@jtrh
rtc.data_models: Add "cesión" natural key and alternative natural key
fbc5bb2 
- Add `CesionNaturalKey` class.
- Add `CesionAltNaturalKey` class.
- Add tests.
@jtrh
rtc.data_models_cesiones_periodo: Replace hardcoded values w/constants
47775b8 
Use `CESION_MONTO_CEDIDO_FIELD_MIN_VALUE` constant in validation of
`CesionesPeriodoEntry.monto_cedido`.
@jtrh jtrh force-pushed the feature/add-sii-rtc-constants-and-cesion-nat-keys branch from c15c0a6 to 47775b8 Compare January 6, 2021 20:45
@jtrh jtrh merged commit c2449db into develop Jan 7, 2021
@jtrh jtrh deleted the feature/add-sii-rtc-constants-and-cesion-nat-keys branch January 7, 2021 13:46
@jtrh jtrh mentioned this pull request Jan 11, 2021
Merged
@jtrobles-cdd jtrobles-cdd added enhancement New feature or request and removed feature labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glarrain glarrain Awaiting requested review from glarrain

Assignees

@jtrh jtrh

Labels

component: rtc enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtrh @jtrobles-cdd