Skip to content

Conversation

@svillegas-cdd
Copy link
Contributor

@svillegas-cdd svillegas-cdd commented Mar 13, 2023

Ref: #428
Resolves: #428 (comment)
Resolves: #428 (comment)

@svillegas-cdd svillegas-cdd requested review from a team and jtrobles-cdd March 13, 2023 21:15
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 8421aee and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bda52df) 85.86% compared to head (8421aee) 85.86%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #462   +/-   ##
========================================
  Coverage    85.86%   85.86%           
========================================
  Files           34       34           
  Lines         2788     2788           
  Branches       356      356           
========================================
  Hits          2394     2394           
  Misses         256      256           
  Partials       138      138           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jtrobles-cdd jtrobles-cdd added bug Something isn't working dependencies Pull requests that update a dependency file labels Mar 13, 2023
@jtrobles-cdd jtrobles-cdd changed the title fix: Update minimum version of signxml to 3.1.0 Update minimum version of signxml to 3.1.0 Mar 13, 2023
Copy link
Member

@jtrobles-cdd jtrobles-cdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, please use the branch name prefix bugfix instead of fix.

@svillegas-cdd svillegas-cdd merged commit f6feb5b into develop Mar 14, 2023
@svillegas-cdd svillegas-cdd deleted the fix/update-dependency-constraints branch March 14, 2023 12:32
@svillegas-cdd svillegas-cdd mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants