rut: Improve type annotation; Add method to validate DV #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Rut.__init__()` is able to accept values of type `Rut` by converting them to `str`, so a more appropriate type annotation for `value` is `str | Rut` instead of just `str`.
This method is useful when we want to validate the DV of a `Rut` that was instantiated with `validate_dv=False`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #721 +/- ##
===========================================
+ Coverage 87.61% 87.63% +0.01%
===========================================
Files 38 38
Lines 3134 3139 +5
Branches 386 386
===========================================
+ Hits 2746 2751 +5
Misses 246 246
Partials 142 142 ☔ View full report in Codecov by Sentry. |
|
fpinto-cdd
approved these changes
Oct 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rut(value).Rut.__init__()is able to accept values of typeRutby converting them tostr, so a more appropriate type annotation forvalueisstr | Rutinstead of juststr.validate_dv()toRut. This method is useful when we want to validate the DV of aRutthat was instantiated withvalidate_dv=False.Rut.__init__().