extras: Fix generation of JSON Schema for Pydantic Rut type
#725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #725 +/- ##
===========================================
+ Coverage 87.65% 87.67% +0.02%
===========================================
Files 38 38
Lines 3142 3149 +7
Branches 386 386
===========================================
+ Hits 2754 2761 +7
Misses 246 246
Partials 142 142 ☔ View full report in Codecov by Sentry. |
Attempting to generate a JSON Schema using
`pydantic.BaseModel.model_json_schema()` or
`pydantic.TypeAdapter.json_schema()` fails with the following error message:
> pydantic.errors.PydanticInvalidForJsonSchema:
> Cannot generate a JsonSchema for core_schema.PlainValidatorFunctionSchema ({
> 'type': 'no-info',
> 'function': <function _RutPydanticAnnotation.__get_pydantic_core_schema__.<locals>.validate_from_str at 0x…>
> })
This commit fixes the above error by implementing `__get_pydantic_json_schema__`
to override the generated JSON Schema.
jtrobles-cdd
force-pushed
the
bugfix/pydantic-rut-json-schema-generation-fails
branch
from
a8989fa to
dee3fa7
Compare
|
jtrobles-cdd
deleted the
bugfix/pydantic-rut-json-schema-generation-fails
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to generate a JSON Schema using
pydantic.BaseModel.model_json_schema()orpydantic.TypeAdapter.json_schema()fails with the following error message:This commit fixes the above error by implementing
__get_pydantic_json_schema__to override the generated JSON Schema.