Skip to content

cte: Allow four digit Form 29 codes #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2020
Merged

cte: Allow four digit Form 29 codes #97

merged 3 commits into from
Feb 25, 2020

Conversation

@jtrh
Copy link
Contributor

@jtrh jtrh commented Jan 31, 2020

Fixes (partially): #93

@jtrh jtrh self-assigned this Jan 31, 2020
@jtrh jtrh force-pushed the feature/allow-4-digit-sii-form29-codes branch from 95ef409 to 6c5bd40 Compare February 24, 2020 14:43
@codecov-io
Copy link

codecov-io commented Feb 24, 2020 •
edited
Loading

Codecov Report

Merging #97 into develop will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #97      +/-   ##
===========================================
+ Coverage    79.69%   80.18%   +0.48%     
===========================================
  Files           25       25              
  Lines         1645     1645              
  Branches       253      253              
===========================================
+ Hits          1311     1319       +8     
+ Misses         228      221       -7     
+ Partials       106      105       -1
Impacted Files Coverage Δ
cl_sii/cte/f29/data_models.py 91.91% <ø> (ø) ⬆️
cl_sii/cte/f29/parse_datos_obj.py 82.81% <0%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d2d96...19bdab2. Read the comment docs.

@jtrh jtrh force-pushed the feature/allow-4-digit-sii-form29-codes branch from 6c5bd40 to 2f0533b Compare February 24, 2020 20:32
@jtrh jtrh marked this pull request as ready for review February 24, 2020 20:36
@jtrh jtrh requested a review from glarrain February 24, 2020 20:36
@jtrh jtrh force-pushed the feature/allow-4-digit-sii-form29-codes branch from 2f0533b to 19bdab2 Compare February 25, 2020 14:53
@jtrh jtrh merged commit 228a626 into develop Feb 25, 2020
@jtrh jtrh deleted the feature/allow-4-digit-sii-form29-codes branch February 25, 2020 15:09
glarrain
glarrain reviewed Feb 25, 2020
View reviewed changes
Copy link
Contributor

@glarrain glarrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jtrh jtrh mentioned this pull request Mar 20, 2020
Merged
@jtrh jtrh mentioned this pull request Apr 7, 2020
Closed
@jtrobles-cdd jtrobles-cdd added bug Something isn't working and removed bugfix labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@glarrain glarrain glarrain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jtrh jtrh

Labels

bug Something isn't working component: cte

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jtrh @codecov-io @glarrain @jtrobles-cdd