Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

Conversation

@zaida04
Copy link
Member

@zaida04 zaida04 commented Feb 26, 2021

closes #29
badabing badaboom

edit:
This PR will also house fixes for several rest/router bugs.
closes #46

edit 2 (from @didinele):
This PR will also lead to the doom of @cordis/snowflake and breaking changes in @cordis/common

Progress:

Audit Log

  • fetchAuditLog

Channel

  • fetchChannel
  • editChannel - encapsulate permissions
  • deleteChannel
  • fetchChannelMessages/fetchChannelMessage
  • sendMessage
  • crosspostMessage
  • addMessageReaction
  • deleteOwnMessageReaction
  • deleteUserReaction
  • deleteAllReactions
  • deleteReaction
  • fetchMessageReactions
  • editMessage
  • deleteMessage
  • bulkDeleteMessages
  • fetchChannelInvites
  • createChannelInvite
  • followNewsChannel
  • startTyping
  • fetchPinnedChannelMessages
  • deletePinnedChannelMessage
  • addPinnedChannelMessage
  • groupDMAddRecipient
  • groupDMRemoveRecipient

Emoji

  • fetchGuildEmojis
  • fetchGuildEmoji
  • createGuildEmoji
  • editGuildEmoji
  • deleteGuildEmoji

Guild

  • createGuild
  • fetchGuild
  • fetchGuildPreview
  • editGuild
  • deleteGuild
  • fetchGuildChannels
  • createGuildChannel
  • fetchGuildMember
  • addGuildMember
  • editGuildMember
  • setNickname
  • addRole
  • removeRole
  • kickMember
  • fetchGuildBans
  • fetchGuildBan
  • banMember
  • unbanMember
  • fetchRoles
  • createRole
  • setRolePosition
  • editRole
  • deleteRole
  • pruneGuild
  • getPredictedPruneResult
  • fetchGuildVoiceRegions
  • fetchGuildInvites
  • createGuildIntegration
  • editGuildIntegration
  • deleteGuildIntegration
  • syncGuildIntegration
  • fetchGuildWidget
  • editGuildWidget (settings too)
  • fetchGuildVanityURL
  • fetchGuildWidgetImage

Invite

  • fetchInvite
  • deleteInvite

Template

  • fetchTemplate
  • createGuildFromTemplate
  • fetchGuildTemplates
  • createGuildTemplate
  • syncGuildTemplate
  • modifyGuildTemplate
  • deleteGuildTemplate

User

  • fetchCurrentUser
  • fetchUser
  • editCurrentUser
  • leaveGuild
  • fetchDMs
  • createDM
  • createGroupDM
  • getUserConnections

Webhooks

  • createWebhook
  • fetchChannelWebhooks
  • fetchGuildWebhooks
  • fetchWebhook (with token too)
  • editWebhook (with token too)
  • deleteWebhook (with token too)
  • executeWebhook
  • editWebhookMessage
  • deleteWebhookMessage

Copy link
Contributor

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and also, pnpm i to update the lock file so CI passes.

@didinele
Copy link
Contributor

didinele commented Mar 5, 2021

Was just writing some code and figured we could also throw a few BitField implementations into this package.

Example: https://github.com/cordis-lib/cordis/blob/7cdefd8cba6343a5293107b42bf76632b378699d/libs/gateway/src/Intents.ts

That one it makes sense to keep in @cordis/gateway, as to not create a reundant dependency on @cordis/util, but otherwise for things like Permissions we could dump 'em here.

If you feel the inconsistency is too much we could move Intents to @cordis/common and have @cordis/util re-export, I wouldn't really mind that dependency chain.

@zaida04
Copy link
Member Author

zaida04 commented Mar 5, 2021

I think keeping Intents in gateway is fine, since it's a gateway only thing. I'm also fine with having BitField implementations like permissions in @cordis/util.

@didinele
Copy link
Contributor

didinele commented Mar 5, 2021

Also, also, an embed builder? 👀

@didinele didinele marked this pull request as ready for review March 9, 2021 14:12
@didinele didinele removed the s: wip label Mar 9, 2021
Copy link
Contributor

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zaida04 zaida04 changed the title @cordis/util BREAKING!: feat @cordis/util Mar 9, 2021
didinele
didinele previously approved these changes Mar 9, 2021
@didinele
Copy link
Contributor

didinele commented Mar 10, 2021

Could you remove routers from the ROOT readme? Just noticed that's a problem.

Meant for #59

didinele
didinele previously approved these changes Mar 12, 2021
Copy link
Contributor

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now in a merge-able state 🎉

didinele
didinele previously approved these changes Mar 12, 2021
Copy link
Contributor

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve since commit that makes CI pass.

Which reminds me, if you got get the test coverage for embed up before we merge this (Sunday), that'd be awesome.

If you wanna see what's being covered/isn't: run the tests (tip: you can use pnpm run test "--" --watchAll) and open coverage/lcov-report/index.html and navigate to the embed file.

@didinele didinele merged commit 7e50239 into main Mar 13, 2021
@didinele didinele deleted the feat/cordis/util branch March 13, 2021 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rest/router POST should be able to take querystring params @cordis/util

3 participants