-
Notifications
You must be signed in to change notification settings - Fork 1
BREAKING!: feat @cordis/util #32
Conversation
didinele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh and also, pnpm i to update the lock file so CI passes.
… into feat/cordis/util
|
Was just writing some code and figured we could also throw a few That one it makes sense to keep in If you feel the inconsistency is too much we could move |
|
I think keeping Intents in gateway is fine, since it's a gateway only thing. I'm also fine with having BitField implementations like permissions in @cordis/util. |
|
Also, also, an embed builder? 👀 |
didinele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Meant for #59 |
didinele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now in a merge-able state 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approve since commit that makes CI pass.
Which reminds me, if you got get the test coverage for embed up before we merge this (Sunday), that'd be awesome.
If you wanna see what's being covered/isn't: run the tests (tip: you can use pnpm run test "--" --watchAll) and open coverage/lcov-report/index.html and navigate to the embed file.

closes #29
badabing badaboom
edit:
This PR will also house fixes for several rest/router bugs.
closes #46
edit 2 (from @didinele):
This PR will also lead to the doom of
@cordis/snowflakeand breaking changes in@cordis/commonProgress:
Audit Log
Channel
Emoji
Guild
Invite
Template
User
Webhooks