Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding epmin and epmax conditional control attributes #20

Merged
merged 14 commits into from Sep 25, 2020

Conversation

asoloway64
Copy link
Contributor

@asoloway64 asoloway64 commented Sep 23, 2020

No description provided.

@@ -106,6 +105,7 @@ Conditional Control Attributes are defined below:
| Attribute | Parameter | Value |
| Minimum Period (s)| pmin | xs:decimal (>0) |
| Maximum Period (s)| pmax | xs:decimal (>0) |
| Change Step | st | xs:decimal (>0) |
Copy link
Contributor

@bsilverajan bsilverajan Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added change step to this table to keep it consistent with its usage together with pmin and pmax. Does this sound good?

Copy link
Contributor Author

@asoloway64 asoloway64 Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 'st' be in the Notification Attributes table?

@@ -106,6 +105,7 @@ Conditional Control Attributes are defined below:
| Attribute | Parameter | Value |
| Minimum Period (s)| pmin | xs:decimal (>0) |
| Maximum Period (s)| pmax | xs:decimal (>0) |
| Change Step | st | xs:decimal (>0) |
| Minimum Evaluation Period (s)| epmin | xs:decimal (>0) |
| Maximum Evaluation Period (s)| epmax | xs:decimal (>0) |
{: #weblinkattributes title="Conditional Control Attributes"}
Copy link
Contributor

@bsilverajan bsilverajan Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Travis CI build is failing on this document owing to "weblinkattributes" being a duplicate label from the previous table. I think it's better to rename "weblinkattributes" on this line to, for example, "controlattributes".

Copy link
Contributor Author

@asoloway64 asoloway64 Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change #weblinkattributes to #notificationattributes in the Notification Attributes as well?

Copy link
Contributor Author

@asoloway64 asoloway64 Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any documentation on this title format and it only displays as a table entry for me. I am using the browser for github access.

@bsilverajan bsilverajan merged commit e3cc20d into core-wg:master Sep 25, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants