go routine leak #1233
Closed
go routine leak #1233
Labels
Comments
May be related to #1235 |
Think it is the healthchecking |
dumping go-routines. This first one is increasing
|
Hmmm, it goes down as well. |
Using more minimal Corefile:
|
This was referenced Nov 16, 2017
miekg
added a commit
to miekg/dns
that referenced
this issue
Nov 16, 2017
When and higher level (grammar or syntax) error was encountered when parsing records from strings the routine would return, but the openend channel would be left open and no other error would be triggered; this means the goroutine starting z.lexer would be left hanging. The fix is a bit of a hack; as we signal the upper error back down via s.e and the trigger an "error" in the lexer, this at least ensure the z.lexer function return and cleans up the goroutine. Fixes #586 Fixes coredns/coredns#1233
miekg
added a commit
to miekg/dns
that referenced
this issue
Nov 16, 2017
When a higher level (grammar or syntax) error was encountered the lower level zlexer routine would be left open. This leaks a goroutine. This PR fixes this by signalling this error, retrieving any remaining items from the channel, so zlexer can return. Fixes #586 Fixes coredns/coredns#1233
miekg
added a commit
to miekg/dns
that referenced
this issue
Nov 17, 2017
When a higher level (grammar or syntax) error was encountered the lower level zlexer routine would be left open and trying to send more tokens on the channel c. This leaks a goroutine, per failed parse... This PR fixes this by signalling this error - by canceling a context - retrieving any remaining items from the channel, so zlexer can return. It also adds a goroutine leak test that can be re-used in other tests, the TestParseBadNAPTR test uses this leak detector. The private key parsing code had the same bug and is also fixed in this PR. Fixes #586 Fixes coredns/coredns#1233
miekg
added a commit
to miekg/dns
that referenced
this issue
Nov 17, 2017
* txt parser: fix goroutine leak When a higher level (grammar or syntax) error was encountered the lower level zlexer routine would be left open and trying to send more tokens on the channel c. This leaks a goroutine, per failed parse... This PR fixes this by signalling this error - by canceling a context - retrieving any remaining items from the channel, so zlexer can return. It also adds a goroutine leak test that can be re-used in other tests, the TestParseBadNAPTR test uses this leak detector. The private key parsing code had the same bug and is also fixed in this PR. Fixes #586 Fixes coredns/coredns#1233 * sem not needed anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See: https://snapshot.raintank.io/dashboard/snapshot/OQ0upeF7EFPoRW2Dfgl9XHzD0c7OSZXY
This is my local proxy.
config:
Only diff. with my auth server is cache and proxy so either one is suspect.
The text was updated successfully, but these errors were encountered: