Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/auto|file: Add deprecation notice for NO_RELOAD #2536

Open
stp-ip opened this Issue Feb 8, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@stp-ip
Copy link
Member

stp-ip commented Feb 8, 2019

Similar notice as done in #2516 for TIMEOUT.

Necessary for full deprecation.

@nzoueidi

This comment has been minimized.

Copy link

nzoueidi commented Feb 14, 2019

Hey, can I work on this issue? :)

@stp-ip

This comment has been minimized.

Copy link
Member Author

stp-ip commented Feb 15, 2019

That sounds awesome. A good example on how this can be implemented is available in the mentioned PR #2516

@ihac

This comment has been minimized.

Copy link
Contributor

ihac commented Feb 28, 2019

@nzoueidi Hi, are you still working on this? If not I'd like to help.
According to @stp-ip 's plan (Issue 2537), this work seems to be straightforward. But I'm not sure whether we need to fully deprecate no_reload and timeout right now.
If we're going to add deprecation notice for no_reload (not fully deprecated), I think a single warning statement in plugin/file/setup.go and plugin/auto/setup.go should be enough.
WDYT? @stp-ip

@stp-ip

This comment has been minimized.

Copy link
Member Author

stp-ip commented Feb 28, 2019

Yeah both should not be fully deprecated yet. Just the note for now and then in the next release we can add the deprecation in the release note and according to our deprecation policy prepare the actual deprecation in the future for both no_reload and the various timings.

Also haven't heard from @nzoueidi on progress.

@stp-ip

This comment has been minimized.

Copy link
Member Author

stp-ip commented Feb 28, 2019

@nzoueidi

This comment has been minimized.

Copy link

nzoueidi commented Feb 28, 2019

Sorry for the delay. Yes I am working on it.
Looks like by tonight or tomorrow I will push a PR.

Edit: Sorry for the delay. I had to handle some stuff IRL. I see that @ihac has already pushed a PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.