Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graceful restart broke #4

Closed
miekg opened this issue Mar 18, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@miekg
Copy link
Member

commented Mar 18, 2016

Haven't tested it, but I am pretty sure graceful restart does work anymore. We need
a) tests if this is the case
b) fix it

@miekg

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2016

indeed broken

2016/04/09 20:06:16 [INFO] SIGUSR1: Reloading
2016/04/09 20:06:16 [INFO] Restarting
2016/04/09 20:06:16 [INFO] Transferred: miek.nl.
2016/04/09 20:06:16 listen udp :1053: bind: address already in use
2016/04/09 20:06:16 [ERROR] Restart: child failed to initialize (exit status 1) - changes not applied
@miekg

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2016

Graceful restart restarts the entire server, which in turns leads to reparsing of all zones, etc. Just an inotify on the zone file is also a neat feature.

@miekg miekg added the bug label Apr 20, 2016

@miekg miekg added the priority label Apr 28, 2016

@miekg

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2016

one-the-fly zone reloading has been implemented, maybe we should reparse zones on reload? Anyway that is later concern. Lets first fix this.

miekg added a commit that referenced this issue Apr 28, 2016

Fix graceful reload
Fix CoreDNS graceful reloading. This uses the same stuff as Caddy
(obviously), but extends it for UDP listeners as well. Also add to the
README that we *will* call Shutdown for middleware.

Fixes #4

@miekg miekg closed this in a1478f8 Apr 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.