Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: plugin/sign: add README for DNSSEC #2949

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
3 participants
@miekg
Copy link
Member

commented Jul 1, 2019

Talk about how DNSSEC options would look like, if implemented.

Signed-off-by: Miek Gieben miek@miek.nl

WIP: plugin/file: update README for DNSSEC
Talk about how DNSSEC options would look like, if implemented.

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

I forgot who else is interested in this; but this is an initial dump of what I'm planning to add to the file plugin.

@miekg miekg referenced this pull request Jul 1, 2019

Open

Add coredns-keygen #2950

@johnbelamaric

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

  1. why not a separate plugin for this?
  2. could coredns-keygen also be a plugin or is that nonsensical?
@miekg

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

WIP: create new plugin *sign*
This can indeed be done by a new plugin, *sign*.

Signed-off-by: Miek Gieben <miek@miek.nl>

@miekg miekg changed the title WIP: plugin/file: update README for DNSSEC WIP: plugin/sign: add README for DNSSEC Jul 1, 2019

@miekg

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

yep, separate plugin is, in fact, very easy to do. Propose the name sign for this, as dnssec is already taken.
Need to copy and paste some things from the dnssec plugin into this one and code a bit, but looks fairly easy.

Added benefit; I think this will now work out of the box with the auto plugin as well.

@miekg

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

coredns-keygen can be completely kept outside the main repo.

Remove Corefile types on the text
Signed-off-by: Miek Gieben <miek@miek.nl>
@codecov-io

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #2949 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2949      +/-   ##
==========================================
- Coverage   55.78%   55.72%   -0.06%     
==========================================
  Files         205      205              
  Lines       10311    10311              
==========================================
- Hits         5752     5746       -6     
- Misses       4141     4146       +5     
- Partials      418      419       +1
Impacted Files Coverage Δ
plugin/forward/connect.go 81.69% <0%> (-4.23%) ⬇️
plugin/route53/route53.go 84.28% <0%> (-2.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0c7c6...a849626. Read the comment docs.

sign: README: update docs
Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

closing for now, while I work on this.

@miekg miekg closed this Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.