Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/hosts: create inline map in setup #3071

Merged
merged 2 commits into from Jul 31, 2019

Conversation

@miekg
Copy link
Member

commented Jul 31, 2019

The inline map wasn't create in the setup.go fuction leading to a crash,
which is masked by a recover (but leads to a SERVFAIL, and not logging
the request).

Various other simplifications.

host plugin could use some test that actually cover these edgecases.

plugin/hosts: create inline map in setup
The inline map wasn't create in the setup.go fuction leading to a crash,
which is masked by a recover (but leads to a SERVFAIL, and not logging
the request).

Various other simplifications.

host plugin could use some test that actually cover these edgecases.

Signed-off-by: Miek Gieben <miek@miek.nl>
@corbot

This comment has been minimized.

Copy link

commented Jul 31, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked johnbelamaric (via plugin/hosts/OWNERS) for a review.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@johnbelamaric
Copy link
Member

left a comment

Minor tweeks otherwise lgtm

plugin/hosts/README.md Outdated Show resolved Hide resolved
plugin/hosts/README.md Outdated Show resolved Hide resolved
plugin/hosts/README.md Outdated Show resolved Hide resolved
PR review changes
Signed-off-by: Miek Gieben <miek@miek.nl>

@miekg miekg merged commit 07f0161 into master Jul 31, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
stickler-ci No lint errors found.

@corbot corbot bot deleted the host-things branch Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.