Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: log panics #3072

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@miekg
Copy link
Member

commented Jul 31, 2019

These are too hidden now. They increase the issue-load, because people
don't see them.

Add log.Errorf in the core/dnsserver recover routine.

core: log panics
These are too hidden now. They increase the issue-load, because people
don't see them.

Add log.Errorf in the core/dnsserver recover routine.

Signed-off-by: Miek Gieben <miek@miek.nl>

@corbot corbot bot requested a review from bradbeam Jul 31, 2019

@corbot

This comment has been minimized.

Copy link

commented Jul 31, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked bradbeam (via /OWNERS) for a review.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@dilyevsky

This comment has been minimized.

Copy link
Collaborator

commented Jul 31, 2019

1428--- FAIL: TestSecondaryZoneTransfer (0.01s)
1429    secondary_test.go:83: Expected answer section

^ appears to be flaky

@miekg

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

thanks (and yes that's flaky and should be fixed)

@miekg miekg merged commit cd5dceb into master Jul 31, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
stickler-ci No lint errors found.

@corbot corbot bot deleted the panic-log branch Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.