Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[plugin/route53]: Increase ListResourceRecordSets paging size. #3073
1. Why is this pull request needed and what does it do?
without the paging parameter set, it will default to 100 records per request. with large enough zones and potentially multiple coredns daemons configured to pull from route 53, this can quickly add up and reach aws global api rate limits (5/sec per root account). increasing paging to max can help reduce the number of requests needed to pull records for a zone without no down side that i am aware of.
2. Which issues (if any) are related?
this helps issue #2353, but probably is not a complete fix.
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?
Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked dilyevsky (via
@@ Coverage Diff @@ ## master #3073 +/- ## ========================================== + Coverage 55.88% 55.88% +<.01% ========================================== Files 205 205 Lines 10118 10119 +1 ========================================== + Hits 5654 5655 +1 Misses 4053 4053 Partials 411 411