Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move federation plugin to github.com/coredns/federation #3139

Merged
merged 6 commits into from Aug 18, 2019

Conversation

@yongtang
Copy link
Member

commented Aug 17, 2019

This PR is part of the effort of #3041 to remove federation plugin.

This is the first step to move federation to github.com/coredns/federation

Note the github.com/coredns/federation was done through

git filter-branch --subdirectory-filter plugin/federation -- --all

so related git history are kept.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

yongtang added 2 commits Aug 17, 2019
Remove federation
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Rebuild and point to github.com/coredns/federation
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

@yongtang yongtang requested a review from miekg Aug 17, 2019

@yongtang yongtang referenced this pull request Aug 17, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Aug 17, 2019

Codecov Report

Merging #3139 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3139      +/-   ##
=========================================
- Coverage   55.73%   55.7%   -0.03%     
=========================================
  Files         210     207       -3     
  Lines       10516   10397     -119     
=========================================
- Hits         5861    5792      -69     
+ Misses       4229    4185      -44     
+ Partials      426     420       -6
Impacted Files Coverage Δ
plugin/kubernetes/local.go 0% <0%> (ø) ⬆️
plugin/route53/route53.go 86.61% <0%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53d822...3e8fe73. Read the comment docs.

@miekg

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

what do we do with plugin/kubernetes/federation.go? Is there any way this can be fully deprecated?

@yongtang

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2019

what do we do with plugin/kubernetes/federation.go? Is there any way this can be fully deprecated?

@miekg It should be possible, although that may need some surgical moving around. Let me update the PR and see if works.

@miekg

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

@yongtang

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2019

@miekg We could move all related logic to coredns/federation there fully. I think we only need to export localNodeName in Kubernetes plugin (for now, until fully deprecated). Let me see if it works.

yongtang added 3 commits Aug 18, 2019
Export `localNodeName` => `LocalNodeName`, to be used by federation (…
…until deprecation)

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Remove plugin/kubernetes/federation.go (=> kubernetes/federation repo)
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Update github.com/coredns/federation
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@@ -21,7 +21,8 @@ func localPodIP() net.IP {
return nil
}

func (k *Kubernetes) localNodeName() string {
// LocalNodeName() is exclusively used in federation plugin, will be deprecated later.

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Aug 18, 2019

comment on exported method Kubernetes.LocalNodeName should be of the form "LocalNodeName ..."

sticker-ci fix
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2019

@miekg I think the PR is ready, please take a look and see if it works.

@miekg
miekg approved these changes Aug 18, 2019

@yongtang yongtang merged commit 6402cef into master Aug 18, 2019

4 checks passed

ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 55.7% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@corbot corbot bot deleted the federation branch Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.