Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Move federation plugin to github.com/coredns/federation #3139
This PR is part of the effort of #3041 to remove federation plugin.
This is the first step to move federation to github.com/coredns/federation
Note the github.com/coredns/federation was done through
so related git history are kept.
Signed-off-by: Yong Tang email@example.com
@@ Coverage Diff @@ ## master #3139 +/- ## ========================================= - Coverage 55.73% 55.7% -0.03% ========================================= Files 210 207 -3 Lines 10516 10397 -119 ========================================= - Hits 5861 5792 -69 + Misses 4229 4185 -44 + Partials 426 420 -6
[ Quoting <firstname.lastname@example.org> in "Re: [coredns/coredns] Move federati..." ]
> what do we do with plugin/kubernetes/federation.go? Is there any way this can be fully deprecated? @miekg It should be possible, although that may need some surgical moving around. Let me update the PR and see if works.
but what I mean is, even with the code in a new repo; if we remove this interface into the kubernetes plugin it will stop working. So recompiling coredns to re-add *federation* will be more involved, because you have to patch more. I'm fine with fully deprecating it, but it will be gone **gone** at some point.