Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/file: respond correctly to IXFR message #3177

Merged
merged 3 commits into from Aug 26, 2019

Conversation

@miekg
Copy link
Member

commented Aug 22, 2019

Respond with a sing SOA record to an IXFR request if the SOA serials
match.

The added test fails on the current code with:

=== RUN   TestIxfrResponse
--- FAIL: TestIxfrResponse (0.00s)
    secondary_test.go:122: Expected answer section with single RR
FAIL
exit status 1

And obviously passes with the new code. This should cut down on the
weird number of zone transfers that I was seeing. At some point IXFR
support might be cool.

Fixes: #3176

@corbot corbot bot requested a review from Isolus Aug 22, 2019

@corbot

This comment has been minimized.

Copy link

commented Aug 22, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked isolus (via /OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 22, 2019

Codecov Report

Merging #3177 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
- Coverage   55.67%   55.63%   -0.05%     
==========================================
  Files         207      207              
  Lines       10397    10411      +14     
==========================================
+ Hits         5789     5792       +3     
- Misses       4187     4199      +12     
+ Partials      421      420       -1
Impacted Files Coverage Δ
plugin/file/xfr.go 0% <0%> (ø) ⬆️
plugin/clouddns/clouddns.go 85.45% <0%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7918190...ba5956b. Read the comment docs.

@miekg

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

relevant RFC 1995, Section 2, para 4

plugin/file: respond correctly to IXFR message
Respond with a sing SOA record to an IXFR request if the SOA serials
match.

The added test fails on the current code with:

~~~
=== RUN   TestIxfrResponse
--- FAIL: TestIxfrResponse (0.00s)
    secondary_test.go:122: Expected answer section with single RR
FAIL
exit status 1
~~~

And obviously passes with the new code. This should cut down on the
weird number of zone transfers that I was seeing. At some point IXFR
support might be cool.

Fixes: #3176

Signed-off-by: Miek Gieben <miek@miek.nl>

@miekg miekg force-pushed the sec-ixfr branch from d7fafb9 to 7624324 Aug 26, 2019

@miekg

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

only fuzzing this is failling

@miekg

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

I need this to go in, so I can start testing it on my server.

miekg added 2 commits Aug 26, 2019
reuse code
Signed-off-by: Miek Gieben <miek@miek.nl>
Sligtht tweaks
Signed-off-by: Miek Gieben <miek@miek.nl>

@miekg miekg merged commit d65cd70 into master Aug 26, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
stickler-ci No lint errors found.

@corbot corbot bot deleted the sec-ixfr branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.